search

VERITAS-Observatory / EventDisplay_v4

A reconstruction and analysis pipeline for VERITAS.
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

makeRadialAcceptance unknown argument and use of loadSimpleFileList for a long run list #243

Closed jywoo0116 closed 12 months ago

jywoo0116 commented 1 year ago

Making run-wise radial acceptance plots for RBM as part of ANALYSIS.anasum_parallel_from_runlist.sh fails due to the following errors.

  1. The argument option -i does not exist for makeRadialAcceptance. (ANALYSIS.anasum_sub.sh line 172 should be removed.)
  2. The input run list for makeRadialAcceptance (FLIST in ANALYSIS.anasum_sub.sh) is a long list, not a short list. makeRadialAcceptance.cpp line 84 should use loadLongFileList, not loadSimpleFileList.

Error 2 was found after removing line 172 in ANALYSIS.anasum_sub.sh and rerunning ANALYSIS.anasum_parallel_from_runlist.sh. Attached are the log files #####.anasum.radialAcceptance.log for error 1 and error 2, respectively.

66658.anasum.radialAcceptance.log_1.log

66658.anasum.radialAcceptance.log_2.log

GernotMaier commented 1 year ago

I actually have removed the functionality to make run-wise radial acceptances in the current development version. I think this has not been tested enough and it only works for long runs and cuts with reasonable high background rates, otherwise statistics are too low. I don't think we should use it.

jywoo0116 commented 1 year ago

Thank you for the quick response, Gernot! That makes sense. Then are we supposed to generate our own acceptance plot? Could you give me some tips for selecting proper runs (and how many of them) to generate the acceptance plot? Or are there wiki pages that I could look at?

GernotMaier commented 1 year ago

Yes, best is to generate your own acceptance curves. You should select for this runs with similar observational parameters in zenith, azimuth, and NSB range.

For very very weak sources, it is acceptable to use the same field of view as for the analysis for the generation of radial acceptances (which makes finding runs with similar patterns easier).

GernotMaier commented 12 months ago

This issue has been solved.