VERITAS-Observatory / EventDisplay_v4

A reconstruction and analysis pipeline for VERITAS.
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Correction generation of AngularLogDiffEmc histograms #80

Closed GernotMaier closed 4 years ago

GernotMaier commented 4 years ago

AngularLogDiffEmc histograms are not filled correctly.

Related to incorrect setting of binning in VInstrumentResponseFunction. Histogram binning is set after the definition of histograms.

--> requires reprocessing of all IRFs.

GernotMaier commented 4 years ago

Test file is here: /lustre/fs19/group/cta/users/maierg/VERITAS//temp/v483_test_eff.root

Please give me feedback.

TarekHC commented 4 years ago

Looks correct to me (the range definitely makes more sense now).

Is a peak of 0.05 deg at 1 TeV reasonable? I would say yes, although not sure about the number of telescopes simulated, etc...

mireianievas commented 4 years ago

I agree it looks fine now and the bugfix seems to be straightforward. Thanks !

GernotMaier commented 4 years ago

All IRFs have been reproduced and are available on UCLA / DESY.