search

VERITAS-Observatory / V2DL3

VERITAS (VEGAS and Eventdisplay) to DL3 Converter
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

Automated and Some Manual Cleaning #116

Closed juniperfdel closed 2 years ago

juniperfdel commented 2 years ago

I ran through the code base with some tools which standardize formatting and automatically refactor some commonly found code. I went through it manually and changed some things as well, the biggest being switching to f-strings and in generateObsHduIndex I changed the if-elif-else chain to a dictionary

GernotMaier commented 2 years ago

Greg - could you indicate which tools you are using and which standard you are following?

We have been using flake8, and we obviously should agree on a common standard / tool / flags. I see e.g, that you have introduced blank lines with whitespaces, which are usually flagged.

juniperfdel commented 2 years ago

I used pycharm's standard formatting tools and sourcery

GernotMaier commented 2 years ago

Thanks a lot. This has been on my todo list as well. I will continue with that and make the code PEP8 compliant, to improve readability and allow for automatic testing.