VERITAS-Observatory / V2DL3

VERITAS (VEGAS and Eventdisplay) to DL3 Converter
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

v2dl3-vegas: Event Selection Patch #146

Closed tmcahill closed 1 year ago

tmcahill commented 2 years ago

This patch utilizes the previously implemented "EventClass" object in order to select events to separate event lists and FITS files. New flags have been tested and output has been reproduced with no differences to main using fitsdiff.

Very little VEGAS-specific review here, so I've added a question about how we utilize VEGAS root data in the previous patch.

For VEGAS Review

Full Changelog

fillEVENTS.py

tmcahill commented 2 years ago

@cameronrulten @GernotMaier All paths now use os.path operations. I also renamed internal event_class variables to event_group related names to be more clear whether or not it is referring specifically to EventClass related operations. Changes are re-tested and working

@cameronrulten Good question on the testing. I do test all of the pull requests, and our demo branch where these features are drafted has also been used and tested by us over the last few months. Right now, the tests are done by hand, unfortunately. I re-run a number of different flag combinations to compare to main using fitsdiff, that way all differences (if any) in output are accounted for. We have a plan to set up CI for automated v2dl3-vegas testing soon.

GernotMaier commented 2 years ago

All fine with me, thanks!