Remove root numpy and process multiple run groups

VERITAS-Observatory / V2DL3

VERITAS (VEGAS and Eventdisplay) to DL3 Converter

BSD 3-Clause "New" or "Revised" License

8 stars 1 forks source link

Remove root numpy and process multiple run groups #177

Closed deividribeiro closed 1 year ago

deividribeiro commented 1 year ago

Remove the usage of root_numpy, which is outdated and no longer supported. Complying with #86 and #88. Fix the loading of multiple run-groups in the runlist. Minor edit to README including instructions for mamba installation alternative (#175).

matthew-w-lundy commented 1 year ago

Tested without root_numpy and files appeared to be generate correctly.

matthew-w-lundy commented 1 year ago

So, big issues in the migration matrix:

but this looks pretty easily solved by modifying the change to irfloader in dce1dcd because it looks like the array was transposed when it wasn't suppose to be. I've attempted this fix here: 7a77317 and this is how the energy bias looks now:

(please ignore my stupid error with n_bins_y in the declaration of a, I fix this is a minor commit.