search

VERITAS-Observatory / V2DL3

VERITAS (VEGAS and Eventdisplay) to DL3 Converter
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

VEGAS bugfixes #198

Closed matthew-w-lundy closed 9 months ago

matthew-w-lundy commented 9 months ago

Adding a lot of functionality to the main and this should replace the previous pull request by @deividribeiro as it contains all of those hotfixes plus the implementation of a couple of other minor fixes. The details can be seen in the individual commits but to summarize:

Some bug fixes:

Solved the issues with single file not working Updated the numbering Made both the single file and the runlist use directory output Added the Experimental Bias correction (turned off by default) Fixed the issues with the migration matrix

matthew-w-lundy commented 9 months ago

Ok I added a bunch of little clean up formatting changes using black to make it pass the formatting test again. The final test is failing but it's unclear to me if that's an issue with the commit or the fact that there is a significant enough change from the main branch because of hotfix patches. It appears to run locally and work well but will require somebody to test on their machine.

matthew-w-lundy commented 9 months ago

Haha! :smile: Finally all checks have passed! This means that we have no differences in basic outputs from the main branch but now we fix the root numpy dependency, make v2dl3-vegas able to be installed, and a couple of various small things.

deividribeiro commented 9 months ago

My own data reproduces these edisp and aeff plots, showing reasonable behavior.

image image

matthew-w-lundy commented 9 months ago

Changes made to meet the request command line change.

After private discussion regard #177, since this includes all of those changes we are planning to do as a part of that PR, we will close that and only merge this.