VERITAS-Observatory / V2DL3

VERITAS (VEGAS and Eventdisplay) to DL3 Converter
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

Event Camera X/Y coordinates #203

Open steob92 opened 6 months ago

steob92 commented 6 months ago

I notice we're using "Xoff/Yoff"

https://github.com/VERITAS-Observatory/V2DL3/blob/e3b59dd48f94d18a34336c3119193dbc23e440d8/pyV2DL3/eventdisplay/fillEVENTS.py#L110-L111

For EVENTS GADF suggests the optional columns:

DETX type: float, unit: deg

        Reconstructed field of view X (see [Field of view](https://gamma-astro-data-formats.readthedocs.io/en/v0.3/general/coordinates.html#coords-fov)).

DETY type: float, unit: deg

        Reconstructed field of view Y (see [Field of view](https://gamma-astro-data-formats.readthedocs.io/en/v0.3/general/coordinates.html#coords-fov)).

I think this is what we're calling Xoff/Yoff?

For gammapy-background-analysis the camera X/Y is required when mimicing and scrambling data.

I've changed this in the 4f1159ef0f3cdbd59a03970fd4b2b9e88daa5b37. I think I caught everywhere on the ED side.

I don't see the camera X/Y stored in the vegas side of things. Is this something that can be easily implemented for vegas?