search

VERITAS-Observatory / V2DL3

VERITAS (VEGAS and Eventdisplay) to DL3 Converter
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

pypi-eventdisplay vegas-ci fix #205

Closed tmcahill closed 5 months ago

tmcahill commented 5 months ago

Found a few fixes to propose to make v2dl3-vegas compatible with the pypi update branch. Will write details here and send the docker credentials within a day or two.

tmcahill commented 5 months ago

Looks like the GitHub secrets aren't working across forks. You can see the CI passed on my test fork here https://github.com/tmcahill/V2DL3-VEGAS-CICD-Test/pull/5

I'll re-make this pull request under a new branch of this repo when I write up the details.

GernotMaier commented 5 months ago

@tmcahill - thanks for this. Do we really need a setup.py file? Is this because of the older version of setuptools in the vegas docker container?

My suggested setup is to consistently use pyproject.toml, which is the recommended way of configuring a python project (including in there is everything which is in pyproject.toml; see here for some background). At this point, we duplicated information between pyproject.toml and setup.py

Did you try with the installation with an emtpy setup.py, as suggested on top of this page?