search

VERITAS-Observatory / gammapy-tools

Repository with tools for gammapy analysis
GNU General Public License v3.0
2 stars 0 forks source link

Too strict gammapy compatibility? #31

Closed matthew-w-lundy closed 5 months ago

matthew-w-lundy commented 5 months ago

"gammapy==1.1" seems very strict, can this be opened to gammapy>1.1 to allow for 1.3 installs?

steob92 commented 5 months ago

That's in requirements.txt? The code has only been tested with 1.1 and 1.2.

We're using pyproject.toml: https://github.com/VERITAS-Observatory/gammapy-tools/blob/ccacd80b784da0827bddf2255b25597be6c72d76/pyproject.toml#L41

requirements.txt will be phased out. The only strict requirement at the moment is SciPy: https://github.com/VERITAS-Observatory/gammapy-tools/blob/ccacd80b784da0827bddf2255b25597be6c72d76/pyproject.toml#L43C6-L43C19

See: https://github.com/gammapy/gammapy/discussions/5034#discussioncomment-8982228

matthew-w-lundy commented 5 months ago

I was looking on main in the pyproject. I see that you have addressed this in a branch that hasn't been merged

https://github.com/VERITAS-Observatory/gammapy-tools/blob/fcf62362592598743b68c05e405a2b416d938f73/pyproject.toml#L33C1-L33C20

matthew-w-lundy commented 5 months ago

But actually this may be too weak a requirement knowing that 0.18 is incompatible

steob92 commented 5 months ago

I seem to remember a bug in gammapy v1.0.2. I've explicitly set the requirement to gammapy>=1.1 771cd3e