search

VEuPathDB / CoreUI

Core UI for VeuPathDB applications. Provides components, style definitions, and utilities to enable developers to rapidly assemble complex applications with consistent UI and UX across our portfolio of sites.
1 stars 0 forks source link

Make Select and Button same height #132

Closed asizemore closed 8 months ago

asizemore commented 1 year ago

Opening for discussion.

In the screenshot below we can see the "medium" size Button is a little larger than the Select components in its row. Since we mostly use the "medium" size button, should we make the Select components the same height?

Screen Shot 2022-12-09 at 3 03 53 PM
dmfalke commented 1 year ago

I agree with this. Perhaps the Select components should use the Button component?

asizemore commented 1 year ago

That sounds ideal. I think the current Button only allows icons on the left. But perhaps SwissArmyButton could be updated so that it supports icons on both sides, and Buttons will always have it on the left but Selects will always have it on the right?

dmfalke commented 1 year ago

That sounds reasonable to me!

asizemore commented 1 year ago

@asizemore double check this is still an issue

asizemore commented 1 year ago

seen on feature mbio today. still an issue. However, this is now less pressing as the new layout for apps will prevent the two being on the same line, so the size difference will be less obvious.