Add support for MaterialUI icons to CoreUI buttons.

VEuPathDB / CoreUI

Core UI for VeuPathDB applications. Provides components, style definitions, and utilities to enable developers to rapidly assemble complex applications with consistent UI and UX across our portfolio of sites.

1 stars 0 forks source link

Add support for MaterialUI icons to CoreUI buttons. #14

Closed bobular closed 2 years ago

bobular commented 2 years ago

Warning: Failed prop type: Invalid prop `fontSize` of value `1.25rem` supplied to `ForwardRef(SvgIcon)`, expected one of ["default","inherit","large","medium","small"].
SvgIcon@https://localhost:3000/static/js/7.chunk.js:30401:18
WithStyles@https://localhost:3000/static/js/7.chunk.js:190735:25
AddIcon

eikonomega commented 2 years ago

Thank you @bobular for this. This appears to happen when an attempt is made to pass an Icon form the material-ui library to the CoreUI button components.

Since this seems to be a fairly common occurrence, I'll look into adding some special login in the button components to play nice with material-ui icons.

eikonomega commented 2 years ago

To my favorite @bobular, this is fixed in the newest version of CoreUI. 0.13.0

As an aside, the best way to use icons is to bring them into CoreUI itself rather than using one from external libraries since each external library creates a different type of component and this problem will probably crop up again.

Thank you for the report!

SheenaTomko commented 2 years ago

QOL improvement for developers. Nothing for outreach to test