search

VEuPathDB / CoreUI

Core UI for VeuPathDB applications. Provides components, style definitions, and utilities to enable developers to rapidly assemble complex applications with consistent UI and UX across our portfolio of sites.
1 stars 0 forks source link

Add `cursor: pointer` to icon used to collapse/expand banners #148

Closed jernestmyers closed 1 year ago

jernestmyers commented 1 year ago

Also, I think we should open a follow-up ticket in CoreUI to change the cursor of the collapsibleIcon to be pointer, which would better indicate that it's a clickable button.

Here's the relevant code in the Banner component.

Definitely I like the idea @jernestmyers: I was thinking the case before but didn't have time to do that. Perhaps you can easily handle it at a follow-up ticket in the near future 😄

Originally posted by @moontrip in https://github.com/VEuPathDB/web-eda/issues/1636#issuecomment-1440638480

dmfalke commented 1 year ago

I think that if an icon is clickable, we should wrap it in a <button> and not an <a>, for accessibility.