search

VEuPathDB / CoreUI

Core UI for VeuPathDB applications. Provides components, style definitions, and utilities to enable developers to rapidly assemble complex applications with consistent UI and UX across our portfolio of sites.
1 stars 0 forks source link

Handle pre-selected row items properly; storybook actions console log addon #62

Closed bobular closed 2 years ago

bobular commented 2 years ago

Workaround for the issue reported here

https://github.com/TanStack/react-table/issues/2459#issuecomment-851523333

When you add isSelected: true to row items that you want to be selected already, it wasn't working properly, but now it is.

bobular commented 2 years ago

Hi @jtlong3rd - thanks for the review. I don't think I will merge just yet. I don't think it's 100% fixed (pre-checked checkboxes aren't uncheckable...) so I will make a story and make sure it is properly fixed.

bobular commented 2 years ago

Right, ready for another quick look please, @jtlong3rd Sorry for the false alarm...

bobular commented 2 years ago

Thanks @jtlong3rd . I've patched the package version and I'm going to merge. But I don't know if that will trigger an npm update automatically?

bobular commented 2 years ago

No urgent need to update npm because the fixes in this PR are no longer used by client code. (It was used by an early iteration of EDA lineplot)