Fix modal content overflow

[chowington]

Warning: not extensively tested! 😅

[asizemore]

@jernestmyers or @chowington are either of you on linux? I'm curious if the changes here may reintroduce some issues people found a while back with the modal styling (slack message). I'm only concerned because i noticed that the changes in this PR revert some of the changes from this commit that fixed some browser compatibility styling issues.

I'm on a mac and things are looking good here btw!

[asizemore]

@jernestmyers or @chowington are either of you on linux? I'm curious if the changes here may reintroduce some issues people found a while back with the modal styling (slack message). I'm only concerned because i noticed that the changes in this PR revert some of the changes from this commit that fixed some browser compatibility styling issues.

I'm on a mac and things are looking good here btw!

[jernestmyers]

@asizemore I'm also on Mac.

[chowington]

@jernestmyers @asizemore Sorry to leave this one hanging while I finished up some subsetting modal work!

I did some storybook testing. As a reminder, here's the 1px overflow we have currently:

Here's the modal in Chrome (on Linux) with my proposed changes (other browsers seemed fine):

100% zoom

80% zoom

So at normal zoom everything is fine, but depending on what other zoom level you're at, we get a 1px white border between the grey border and the content on some sides.

I didn't find a good way around this (somehow), so for now I propose we choose between which visual glitch we would rather live with:

1) 1px content overflow at bottom on all zoom levels & browsers 2) 1px white border on varying sides at varying zoom levels (not 100%) on Chrome

[chowington]

I prefer living with 2

[jernestmyers]

I vote option 2. Much more subtle.

[asizemore]

i vote for 2 as well!