VEuPathDB / EbrcWebsiteCommon

Apache License 2.0
3 stars 3 forks source link

Study details tab: update summary information header #143

Closed danicahelb closed 1 year ago

danicahelb commented 2 years ago

Final mockups are here: https://www.figma.com/file/mDKIOrpnSwwMjz9acRg3qC/Add-data-accessibility-information-(study-details-%26-downloads-tabs)?node-id=47%3A365

image

To do:

The ordering of attributes in the summary section has been moved to a new issue: #175

Text explaining data accessibility:

For users who don’t have access permissions or are not logged in:

For studies with public access:

Data downloads for this study are public. Data is available without logging in.

For studies with controlled access:

To download data please register or log in and request access. Data will be available immediately following request submission.

For studies with protected access:

To download data please register or log in and request access. Data will be available upon study team review and approval.

For users who are logged in and have access to the study data:

For studies with public access:

Data downloads for this study are public. Data is available without logging in.

For studies with controlled access:

You have been granted access to download the data.

For studies with protected access:

You have been granted access to download the data.

Note: request access is a link that should take you to the popup:

image
dmfalke commented 2 years ago

Most of this work can be done in https://github.com/VEuPathDB/EbrcWebsiteCommon/blob/master/Client/src/components/records/DatasetRecordClasses.DatasetRecordClass.jsx.

We will also want to remove the record scope from study_access in https://github.com/VEuPathDB/EbrcModelCommon/blob/3a629ddf723538410ba712db0f1771f465823f3c/Model/lib/wdk/ontology/commonIndividuals.txt#L63.

sweverschulman commented 1 year ago
Screen Shot 2022-11-04 at 11 10 23 AM

Changes seem to have not been made to the qa site. The ordering is still incorrect and there question mark.

dmfalke commented 1 year ago

It looks like I used the wrong scope for this attribute. I also missed the part about changing the order above. Note that the latter will impact genomic sites, so I think I will make a new issue for that and get feedback from the genomics ux group.

SheenaTomko commented 1 year ago

This is done