On the genomics local dev environment, navigate to https://localhost:3000/a/app/workspace/datasets/help#sample
You'll see an infinite loop of static content network calls (closer inspection reveals that the ExternalContentController is being repeatedly mounted and unmounted)
This PR resolves the infinite loop by changing the way we scroll to the hash specified by the ExternalContentController's url - now, the scrolling is handled by our scrollIntoView DOM utility, instead of location.assign.
(To test, yarn link / npm-pack-here / relative-deps this PR's branch to the ApiCommonWebsite branch indicated above. Repeating the steps above should not trigger the infinite loop.)
How to reproduce the bug:
https://localhost:3000/a/app/workspace/datasets/help#sampleExternalContentControlleris being repeatedly mounted and unmounted)This PR resolves the infinite loop by changing the way we scroll to the hash specified by the
ExternalContentController's url - now, the scrolling is handled by ourscrollIntoViewDOM utility, instead oflocation.assign.(To test,
yarn link/npm-pack-here/relative-depsthis PR's branch to the ApiCommonWebsite branch indicated above. Repeating the steps above should not trigger the infinite loop.)