VEuPathDB / EdaDataService

Apache License 2.0
2 stars 0 forks source link

SAM - standalone scatterplot response for binned continuous overlay is possibly malformed #285

Open bobular opened 1 year ago

bobular commented 1 year ago

I know we might disable scatterplot but here is an issue I've noticed.

In the "regular" scatterplot, continuous overlay variables are handled as a continuous, unbinned, overlay. The color scale values are returned in the scatterplot.data[].seriesGradientColorscale prop, which is next to seriesX and seriesY

(Note, seriesGradientColorscale doesn't seem to be in any raml documentation?)

The standalone map version of the plugin is also returning seriesGradientColorscale with values such as "(8.6, 16.2]" - but I think it should be returning different strata in scatterplot.data described by overlayVariableDetails? Here is the request POST (SCORE S. mansoni)

{
    "config": {
        "outputEntityId": "EUPATH_0000609",
        "overlayConfig": {
            "overlayType": "continuous",
            "overlayValues": [
                {
                    "binEnd": "8.6",
                    "binLabel": "[1, 8.6]",
                    "binStart": "1"
                },
                {
                    "binEnd": "16.2",
                    "binLabel": "(8.6, 16.2]",
                    "binStart": "8.6"
                },
                {
                    "binEnd": "23.8",
                    "binLabel": "(16.2, 23.8]",
                    "binStart": "16.2"
                },
                {
                    "binEnd": "31.4",
                    "binLabel": "(23.8, 31.4]",
                    "binStart": "23.8"
                },
                {
                    "binEnd": "39",
                    "binLabel": "(31.4, 39]",
                    "binStart": "31.4"
                },
                {
                    "binEnd": "46.6",
                    "binLabel": "(39, 46.6]",
                    "binStart": "39"
                },
                {
                    "binEnd": "54.2",
                    "binLabel": "(46.6, 54.2]",
                    "binStart": "46.6"
                },
                {
                    "binEnd": "61.8",
                    "binLabel": "(54.2, 61.8]",
                    "binStart": "54.2"
                },
                {
                    "binEnd": "69.4",
                    "binLabel": "(61.8, 69.4]",
                    "binStart": "61.8"
                },
                {
                    "binEnd": "77",
                    "binLabel": "(69.4, 77]",
                    "binStart": "69.4"
                }
            ],
            "overlayVariable": {
                "entityId": "EUPATH_0000096",
                "variableId": "OBI_0003075"
            }
        },
        "valueSpec": "raw",
        "xAxisVariable": {
            "entityId": "EUPATH_0000096",
            "variableId": "EUPATH_0030005"
        },
        "yAxisVariable": {
            "entityId": "EUPATH_0000609",
            "variableId": "EUPATH_0030024"
        }
    },
    "filters": [
        {
            "entityId": "EUPATH_0035127",
            "max": -0.35617360550843846,
            "min": -0.3606957214165074,
            "type": "numberRange",
            "variableId": "OBI_0001620"
        },
        {
            "entityId": "EUPATH_0035127",
            "left": 35.570012927055366,
            "right": 35.578274130821235,
            "type": "longitudeRange",
            "variableId": "OBI_0001621"
        }
    ],
    "studyId": "SCORECX01-1"
}

And here is a screenshot of the response

image