VEuPathDB / EdaDataService

Apache License 2.0
2 stars 0 forks source link

Temporary provision of displayName #306

Closed bobular closed 1 year ago

bobular commented 1 year ago

This is strange,

The first null argument given here is creating a null displayName https://github.com/VEuPathDB/EdaDataService/blame/536fffc82ca370b9de67c7518e69f3f653209861/src/main/java/org/veupathdb/service/eda/ds/metadata/AppsMetadata.java#L76

which is violating the non-null string requirement here in the client: https://github.com/VEuPathDB/web-monorepo/blob/391be70e7bee2935d7d7b9aa726c8ec3cf797126/packages/libs/eda/src/lib/core/types/visualization.ts#L88

But, according to the blame, the EdaDataService change was made a month ago, and the client types unchanged for a year, yet this was working fine on dev yesterday. I guess the more recent merge (2 days ago) https://github.com/VEuPathDB/EdaDataService/commit/536fffc82ca370b9de67c7518e69f3f653209861#diff-bd0dc4004e140f982fca8ef9a3db1026f18245e93918889411ca662643a7dc58 is what really matters, and maybe the apps response was cached somehow since that merge?

Anyway, here is a temporary fix.