search

VEuPathDB / EdaDataService

Apache License 2.0
2 stars 0 forks source link

Support dates for bubble markers #309

Closed dmgaldi closed 1 year ago

dmgaldi commented 1 year ago

Resolves https://github.com/VEuPathDB/EdaDataService/issues/304

Mostly just moving things around. Needed to support alternate string -> double conversions.

bobular commented 1 year ago

I've started doing the front end work for this.

bobular commented 1 year ago

@dmfalke and I discussed how best to handle this on the client side.

We decided that the quite extensive client work (date and number handling is always a bit of a faff) should be done on Dave's refactored branch that will not be merged for b65.

However, we appreciate that we don't want this PR to get stale and we don't want 500 errors for the user.

So we've done some temporary client work to avoid 500 errors and temporarily disable date vars in the client (for bubble markers)

https://github.com/VEuPathDB/web-monorepo/pull/453

I will undraft that PR as soon as I can test web-monorepo#453 against this branch of the services. It seems that only the megastudy and Maine are mappable datasets with date variables?? - these are currently offline.

We should coordinate merging both

bobular commented 1 year ago

To test this against the client, I'll need this updating from master please. I was getting 404s from merging-internal when running this branch locally alongside the other services on latest.