search

VEuPathDB / EdaDataService

Apache License 2.0
2 stars 0 forks source link

return explicit network thresholds #343

Closed d-callan closed 10 months ago

d-callan commented 10 months ago

resolves https://github.com/VEuPathDB/EdaDataService/issues/340

are people ok w the revised api?

d-callan commented 10 months ago

also i think there was another api change we talked about? something about stroke widths vs edge weights. do we have an issue for that? and do we want to handle that at the same time in this pr?

asizemore commented 10 months ago

i think it looks good. Makes sense to keep the thresholds separate from the bipartite network.

Yes we were talking about another api change. let me go find that. I'd love to get that in before release. Doesn't have to be this PR if you're ready to merge.

asizemore commented 10 months ago

found it. The change was "strokeWidth" -> "linkWeight". The link weight is the actual data used for the links. It could be rendered as stroke width, stroke color, whatever. So it's more clear to have this called "linkWeight" instead of "strokeWidth". Also, as @bobular had pointed out, that value won't become the actual stroke width because we have to rescale the values on the frontend so that they span a reasonably visible range of widths.