VEuPathDB / EdaNewIssues

0 stars 0 forks source link

Remove ability to choose categorical variables in line plots for b57 #244

Closed SheenaTomko closed 2 years ago

SheenaTomko commented 2 years ago

Users can currently choose categorical variables in line plots for the Y-axis even though we are not going to support proportions for b57. Need to temporarily remove the ability to choose categorical vars.

image

d-callan commented 2 years ago

i thought proportions were going for 57..

SheenaTomko commented 2 years ago

ahh I forgot that. I'll close this ticket then. So we're expecting the proportion functionality soon

d-callan commented 2 years ago

id like @bobular to just look at this and confirm were on track i think. bc im not complete sure i understand the error hes written there and it seems like if a user chooses country for yaxis it should automatically switch the radio button to proportion?

SheenaTomko commented 2 years ago

I think I got very confused and flipped what was supposed to be available on the X and Y axes.

For reference, this error message comes from PRISM without any filtering. Now that I am thinking correctly about which axis is which, I believe this error message is coming because Country should enable proportions, but there is only one value for the variable Country in this study. So there's an error message and we can either 1) remove variables with single values as options, or 2) give people a more distinct error message, or 3) update how proportions work when there is only one possible value.

We can either change the name of this ticket and reopen it, or if you think it's cleaner, I can make a new ticket with the correct description of the issue

d-callan commented 2 years ago

New ticket seems good if you don't mind.

SheenaTomko commented 2 years ago

Done, you can find it here: VEuPathDB/web-eda#1079