search

VEuPathDB / EdaNewIssues

0 stars 0 forks source link

Ranked Abundance: 500 if all values are 0 for chosen ranking method #441

Closed d-callan closed 1 year ago

d-callan commented 1 year ago

can recreate w the FARMM study using WGS > species and the median ranking method. median values of 0 get removed, leaving nothing left to rank. then plot.data accurately complains that it cant make a plot without an xaxis.

this means both front and backend work, w some decisions along the way. how do we want to tell the user about this? what should the message be, how should it be displayed, how does the backend relay that message, etc..

dmfalke commented 1 year ago

We need a generic solution for this, I think. I propose we make this a 422 and use the standard error reporting format. @ryanrdoherty can probably provide some more details on this.

All viz components on the front end will need to be updated to handle this type of response.

dmfalke commented 1 year ago

FWIW, I think a standard 400 response, with a user friendly message would be adequate. We don’t need to make any client side changes in the immediate term, I believe.

asizemore commented 1 year ago

Duplicate of https://github.com/VEuPathDB/microbiomeComputations/issues/22

Let's continue discussion there. Closing!