search

VEuPathDB / EdaNewIssues

0 stars 0 forks source link

Scatter opacity slider changes markers, too #549

Closed asizemore closed 1 year ago

asizemore commented 1 year ago

I think we should pick one marker. Since we have the opacity slider, now it is more reasonable to choose a filled marker, and have the opacity set to 0.7ish by default. So there's a good case for either marker. Regardless, let's pick just one!

Hollow markers

Screen Shot 2023-01-26 at 11 37 51 AM

change opacity...

filled markers

Screen Shot 2023-01-26 at 11 38 20 AM
asizemore commented 1 year ago

also going to 0 exactly gives hollow markers, while 1 gives filled markers. Perhaps this was desired behavior? (i didn't expect that change to happen given the ui, but the idea is kinda cool!)

danicahelb commented 1 year ago

also going to 0 exactly gives hollow markers, while 1 gives filled markers. Perhaps this was desired behavior? (i didn't expect that change to happen given the ui, but the idea is kinda cool!)

Yep, this was an intentional decision!

danicahelb commented 1 year ago

closing ticket. https://github.com/VEuPathDB/web-eda/issues/1605 will switch the default opacity to 0.6. and it was the intention to switch the markers to hollow ones if the user drags the slider to an opacity of 0