VEuPathDB / EdaNewIssues

0 stars 0 forks source link

Bug: cannot collapse entities after using the search bar #573

Open danicahelb opened 1 year ago

danicahelb commented 1 year ago

when i use the search bar on the live site to search for a term in the variable tree, the arrows that allow me to collapse different entities disappear. this is frustrating for studies like maled which have a lot of variables and i know i am interested in terms under "sample"

image
dmfalke commented 1 year ago

This is by design. Perhaps we need to have a UX discussion about this.

dmfalke commented 1 year ago

One of the challenges with allowing the user to expand/collapse in this view is how it impacts the state when the search term changes, or there is no search term at all.

danicahelb commented 1 year ago

@dmfalke I'm not sure what you mean by this:

One of the challenges with allowing the user to expand/collapse in this view is how it impacts the state when the search term changes, or there is no search term at all.

dmfalke commented 1 year ago

What I mean is:

You might have expanded and collapsed some sections before entering a search term. When you enter a search term, do we retain that state and apply it to the trimmed tree? If you expand and collapse sections of the trimmed tree when you have a search, and then remove the search, does the original tree reflect that new state, or do we revert back to the old state?

Part of the rationale for the current functionality is that we want to show all leaves (variables) that match your search term, so we fully expand the tree when a search is active.