VEuPathDB / EdaNewIssues

0 stars 0 forks source link

Mosaic 2x2 table parameter selection frontend update #601

Closed danicahelb closed 1 year ago

danicahelb commented 1 year ago

Hey @jernestmyers this slipped through the cracks, and is fine to fix for b63.

The heading for the facet parameter selector should be Stratification variable (see https://www.figma.com/file/Su1eNm3Bby85CfrnX42L7q/2x2-table-UI?node-id=44%3A169&t=aGyO1qjiYDRcMRLJ-0)

image

Instead, it says 2x2 variables

image

Related to: https://github.com/VEuPathDB/web-eda/issues/1575

jernestmyers commented 1 year ago

Ah, bummer. I can probably open the PR tonight if we'd like to get it into b62.

danicahelb commented 1 year ago

@jernestmyers if that is possible that would be awesome. I don't want to screw up @dmfalke's plans though...

jernestmyers commented 1 year ago

Yeah, I pushed a fix and tagged him for the PR. I'll let him determine if it's worth the hassle. Sorry for the bug 😩

danicahelb commented 1 year ago

no worries! we should have caught it earlier. thanks jeremy

nkittur-uga commented 1 year ago

Fixed on QA!

Screenshot 2023-03-31 at 1 32 15 PM