VEuPathDB / EdaNewIssues

0 stars 0 forks source link

500 error on some number variables `map-markers` request #658

Closed bobular closed 10 months ago

bobular commented 11 months ago

The bug is not currently present on https://qa.clinepidb.org

To reproduce

  1. using the https://dfalke-b.clinepidb.org/eda back end
  2. current (as of writing) main branch (though I don't think this is a client issue)
  3. study: SCORE S. mansoni CRT
  4. Configure donuts or chart markers to use any of these variables :arrow_upper_right: image
  5. doesn't matter which binning method you choose
  6. 500 error
  7. With the one other numeric variable in this study, "Schistosoma mansoni infection intensity, by microscopy", it works fine.

Looking at the logs on palm:docker.edadev*.log

It seems that the problem is in EdaDataService

For the percent variables:

java.lang.NumberFormatException: empty String
        at jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1842) ~[?:?]
        at jdk.internal.math.FloatingDecimal.parseDouble(FloatingDecimal.java:110) ~[?:?]
        at java.lang.Double.parseDouble(Double.java:651) ~[?:?]
        at org.veupathdb.service.eda.ds.plugin.standalonemap.markers.OverlaySpecification.lambda$new$0(OverlaySpecification.java:45) ~[service.jar:3.0.0]
        at org.veupathdb.service.eda.ds.plugin.standalonemap.markers.QualitativeOverlayAggregator.addValue(QualitativeOverlayAggregator.java:22) ~[service.jar:3.0.0]

For the integer variables:

java.lang.NumberFormatException: For input string: ""
        at java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) ~[?:?]
        at java.lang.Integer.parseInt(Integer.java:678) ~[?:?]
        at java.lang.Integer.parseInt(Integer.java:786) ~[?:?]
        at org.veupathdb.service.eda.ds.plugin.standalonemap.markers.OverlaySpecification.lambda$new$1(OverlaySpecification.java:47) ~[service.jar:3.0.0]
        at org.veupathdb.service.eda.ds.plugin.standalonemap.markers.QualitativeOverlayAggregator.addValue(QualitativeOverlayAggregator.java:22) ~[service.jar:3.0.0]
bobular commented 11 months ago

Also reproduced with those same variables but from "SCORE Mozambique S. haematobium Cluster Randomized Trial". But in this study "Age" also gives a 500 on map-markers.

Note that this doesn't seem related to https://github.com/VEuPathDB/EdaNewIssues/issues/659 because downloads are working for SCORE Mozambique and yet some number variables are still broken as map marker overlays in this dataset.

bobular commented 11 months ago

Aha, now I can debug a bit more easily in "SCORE Mozambique" because downloads are working there: image

So it's something to do with missing data!

dmfalke commented 11 months ago

Can this issue be moved to EdaLoadingIssues?

bobular commented 10 months ago

This was fixed a while ago.