VEuPathDB / EdaNewIssues

0 stars 0 forks source link

only allow study team members who are managers to be able to approve/deny requests #663

Closed danicahelb closed 9 months ago

danicahelb commented 11 months ago

Currently, everyone listed under “Study team members” is able to approve/deny requests and add/remove end users. Managers are also able to add additional people to "Study team members".

many study team members are very junior and should not be allowed to approve requests. junior study team members should only be able to access data without restrictions.

Please change this so that only Study team members who are also managers can approve/deny requests, add/remove end users, and add/remove study team members.

aurreco-uga commented 11 months ago

@dmgaldi @danicahelb : if we do this, it might complicate emailing: what do we send to all providers, vs what do we send only managers.. best would be we only email managers..

dmgaldi commented 11 months ago

I was looking around and I noticed that this study doesn't have any managers. Do we need to do an audit before making this change?

Maybe that's intended and it means that study's requests would only be approved/denied internally?

danicahelb commented 10 months ago

@dmgaldi Nupur is in the process of updating the ClinEpi presenter xml for all studies, all studies should now have managers

danicahelb commented 10 months ago

@aurreco-uga I agree, only managers should receive emails

nkittur-uga commented 10 months ago

Yes, this works. When I was logged in as a study team member but not manager, I did not see the data dashboard button. When I was logged in as a study team member-manager, I could use the data dashboard button and approve/deny requests. QA is complete.