Fix "Action" and "Notes" in Data Requester Table Updates

[danicahelb]

"Action", "Approval status" and "Notes" columns of Data Requester Table Updates is confusing

See Kalifabougou Malaria Cohort on qa.clinepi:

21 Oct 2023 02:16:24 GMT

• i denied the request.
• Action just says "update" --> what is being updated??? this should indicate "update approval status"
• Notes column indicates status changed to denied and indicates reason --> this is good

21 Oct 2023 02:16:31 GMT -i switched the approval status from denied to requested

• Action column says "update approval status, notes" --> why is it indicating that the "notes" are being updated? this should just say "update approval status"
• Notes column indicates status changed to requested --> this is good

21 Oct 2023 02:17:10 GMT

• i deleted the request
• Action column says "delete" --> this is good
• Notes column indicates Status was changed to Requested --> this is wrong, should say "request deleted"
• Approval status column says "requested" --> this should say "deleted"

[dmgaldi]

I think the action column behavior is a new request. I'll have to familiarize myself with how that column is populated. Can we lay out the desired behavior somewhere?

I don't understand what the action column is supposed to indicate or how it's useful beyond the approval status.

[danicahelb]

providers never see this table, only staff. it is ok as is now