search

VEuPathDB / EdaNewIssues

0 stars 0 forks source link

Map - bubble size endpoint is not taking into account overlay variable "little filter" effects #734

Open bobular opened 7 months ago

bobular commented 7 months ago

It looks like a similar issue to https://github.com/VEuPathDB/EdaNewIssues/issues/733 and others maybe.

Analysis/diagnosis after the examples...

Site: qa.vectorbase.org Study: megastudy Bubble marker variable: enzyme activity ratio (mean population reference)

The ONLY data for this variable is in Singapore. The markers are all way smaller than the bubble size legend which says they could go up to 5000 image

Even when zoomed out to just one marker, it is still nowhere near the 5000 max size shown in the legend: image

With a "catch all" filter for the enzyme activity variable, the sizing is now sensible: image image

I think the max bubble size maxSizeValue: 4542 is the largest marker for the Insecticide resistance assay output entity when it is NOT filtered for "has_any_value_for enzyme activity ratio (mean population reference)"

Do we want to solve this on the front end (send an extra catch-all filter for the overlay variable) or on the back end?

Bear in mind with categorical variables, the front end would have to add a non-trivial filter if the user has checked values in the marker config. However, we will likely be adding front end logic to convert little filters into actual filters anyway, see https://github.com/VEuPathDB/web-monorepo/issues/548 and https://github.com/VEuPathDB/web-monorepo/issues/596

bobular commented 5 months ago

I will have a look at this after the little filter refactor is merged and decide how to tackle/prioritise