search

VEuPathDB / EdaPhaseOneNewIssuesOLD

A skeletal repo that contains new EDA issues that are not yet initially reviewed by the dev team
Apache License 2.0
0 stars 0 forks source link

Date display looks strange when only 1 date #159

Closed SheenaTomko closed 3 years ago

SheenaTomko commented 3 years ago

Example: Kalifabougou Malaria Cohort, variable "Hematological, lymphatic condition end date". This variable only has one value, and it displays as taking up the entire plot with hours on the X-axis, even though you can't choose just one part of that day. I previously made a redmine ticket for this in the old system that John Iodice was going to look at, so this might also need his involvement if we decide to fix it by having a single date appear as a table rather than histogram.

In the current system, I tried setting defaultDisplayRangeMin = 14 Jan 2017, defaultDisplayRangeMax = 20 Nov 2017, and defaultBinWidth = 7 for the variable "Malaria treatment start date" in India ICEMR Severe P. falciparum and vivax. The study wouldn't appear, and Jay indicated it was because you couldn't have a defaultBinWidth of 7 for a date variable. Going to try removing the binWidth but leaving the min and max to see if that works.

Screen Shot 2021-09-28 at 2 05 45 PM
danicahelb commented 3 years ago

Kalifabougou Malaria Cohort needs to be reloaded, this ticket is on pause until then

d-callan commented 3 years ago

just a note that dates have bin widths like 'day', 'week', 'month', 'year'. also plot.data recently had a bug fixed where it wasnt returning a bin width for cases like this, but should now return 'day'.

SheenaTomko commented 3 years ago

Closing this ticket. In India ICEMR Severe P. falciparum and vivax I was able to set the min and max date range and have the bin width be a day. Will use the same solution in Kalifabougou