search

VEuPathDB / EdaPhaseOneNewIssuesOLD

A skeletal repo that contains new EDA issues that are not yet initially reviewed by the dev team
Apache License 2.0
0 stars 0 forks source link

Visualizations: improvements to contingency tables #2

Closed d-callan closed 3 years ago

d-callan commented 3 years ago

sorry if some of these exist as other tickets already.. but looking at it today i had a few thoughts: (im current looking at RxC on the feature site, i tried x axis as floor material and y axis as country in gems)

  1. the white breaks in between the boxes seem to be of differing widths. and worse, when i swap the two vars, i notice they seem to affect the borders of the boxes along the axes. i do not like this at all.
  2. the axes are represented continuously, when theyre actually categorical. typical thing would be to put the xaxis labels along the bottom centered by the first box in that column, and yaxis labels along the left centered by the first box in that row. though ive also seen a few w labels across the top and left, and that would be more consistent w the table, so id be fine w that. id also remove the (%) from the axes labels. you dont usually read these as cumulative percents across values..
  3. sort of related, the handful of these ive encountered in the wild i think theres not usually a legend. and i think that makes sense here as well probably. not sure we want to be able to turn off values for one axis variable and not the other..
  4. think we need to update constraints, since we only have 8 colors? otherwise, only offer the table if a certain number of values is exceeded?
  5. labels are cut off across the top
  6. i feel like when i hover the thing im most interested in is the size/count, since im already getting a visual impression of the proportion. can we swap the two? think thatd also be more consistent w the var coverage table and subset tab fwiw
SheenaTomko commented 3 years ago

Split this into multiple tickets. 1) https://github.com/VEuPathDB/EdaNewIssues/issues/17 2&5) X-axis addressed here: https://github.com/VEuPathDB/EdaNewIssues/issues/15. Y-axis not yet addressed 4) https://github.com/VEuPathDB/EdaNewIssues/issues/13 6) https://github.com/VEuPathDB/EdaNewIssues/issues/14 Y-axis in 2 and point 3 not yet ticketed

dmfalke commented 3 years ago

Can this issue be closed?

SheenaTomko commented 3 years ago

Made 2 and 3 into an issue https://github.com/VEuPathDB/EdaNewIssues/issues/18, so closing this one.