search

VEuPathDB / EdaPhaseOneNewIssuesOLD

A skeletal repo that contains new EDA issues that are not yet initially reviewed by the dev team
Apache License 2.0
0 stars 0 forks source link

Y-axis line should disappear if the X-axis is truncated #93

Closed SheenaTomko closed 3 years ago

SheenaTomko commented 3 years ago

In the subsetting histogram, if the Y-axis min is changed to be >0, the line on the X-axis disappears, but if you do the same to the X-axis, the Y-axis line remains in place.

Instead, if the X-axis min is changed to be >0, the Y-axis line should disappear.

From discussion of https://github.com/VEuPathDB/web-eda/issues/98

moontrip commented 20 hours ago • @bobular May I ask one thing regarding one of Sheena's question ? If I remember correctly, there was a discussion long time ago whether we would show X-axis line (idk what to call it but saying baseline of plot) beyond zero line (i.e., y=0 line) regardless of non-zero y value. I have checked histogram component at web-components and realized that layout.xaxis.showline is set as false, while layout.yaxis.showline is true. To comply with Sheena's suggestion, we need to set layout.xaxis.showline as true. Any thought ?

bobular commented 7 hours ago Hi @moontrip

I think both axes should have zeroline: false and then showline should be false when axisTruncationConfig.xxxx.min is true?

SheenaTomko commented 3 years ago

closing because DK asked for this to be in 1 ticket with other request