search

VEuPathDB / EdaSubsettingService

A REST service to provide data and subsetting in the Exploratory Data Analysis Workspace
Apache License 2.0
0 stars 0 forks source link

Fix the column headers for the primary and foreign keys in the subset modal download to match bulk downloads #51

Closed SheenaTomko closed 2 years ago

SheenaTomko commented 2 years ago

The column header for the primary key doesn't match the column header for our bulk downloads. Change them so: Community_stable_id -> Community_ID CommunityRepeatedMeasure_stable_id -> Community_repeated_measure_ID Household_stable_id -> Household_ID HouseholdRepeatedMeasure_stable_id -> Household_repeated_measure_ID Participant_stable_id -> Participant_ID Observation_stable_id -> Participant_repeated_measure_ID Sample_stable_id -> Sample_ID

If possible, in cases where the entity has been re-labeled (e.g. Community is called Village), have the prefix match the updated label (e.g. Village_ID instead of Community_ID).

ryanrdoherty commented 2 years ago

@danicahelb @SheenaTomko Sorry if I jumped the gun on this. I temporarily forgot our entire SOP when I saw my name on something.

SheenaTomko commented 2 years ago

That's fine @ryanrdoherty! But I don't see any changes to the files on qa.restricted. Do you know if your updates made it in to the last rebuild of the site?

ryanrdoherty commented 2 years ago

To complete this fix, a little client work was needed as well. I wrote a PR for @dmfalke to approve and deploy. Dave, can you comment here when complete? Or put this wherever it should go until it is ready?

dmfalke commented 2 years ago

I've merged your PR and will update the qa site shortly. It should be available for qa tomorrow (Wed, Feb 16).

SheenaTomko commented 2 years ago

This looks great! Checked files from PRISM2, SCORE 5 country, SCORE Niger, WASH-B Bangladesh, and WASH-B Kenya. IDs no longer include "stable" and are updated to the name of the entity, like "Compound" for WASH-B Kenya