search

VEuPathDB / EdaSubsettingService

A REST service to provide data and subsetting in the Exploratory Data Analysis Workspace
Apache License 2.0
0 stars 0 forks source link

Update the column headers for the subset modal download files #52

Closed SheenaTomko closed 2 years ago

SheenaTomko commented 2 years ago

Currently download files generated by the subset & download modal use the IRI (EUPATH_0000093, etc.) as the column header. Instead, the ClinEpiDB outreach team wants the header to be "Variable name [IRI]", for example "Sex [PATO_0000047]". If the variable has a unit, we want the header to be "Variable name (unit) [IRI]", for example "Hemoglobin (g/dL) [EUPATH_0000047]". This will match the headers in the bulk download files.

SheenaTomko commented 2 years ago

When qa'ing the other ticket regarding changes to ID labels, I noticed that the IRI is now successfully added to the column headers. The only thing missing is the unit in parentheses for variables that have units (ex in PRISM2, "Hemoglobin [EUPATH_0000047]" should be "Hemoglobin (g/dL) [EUPATH_0000047]"

ryanrdoherty commented 2 years ago

Fixed.

SheenaTomko commented 2 years ago

Looks good for a lot of variables, but also now have empty () at the end of a lot of variable labels, like for the PRISM Household repeated measure variable "Female Anopheles funestus count () [EUPATH_0000136]". Were the parentheses added for all numeric data? Because we definitely have a large proportion of numeric variables without units because they are simple counts or proportions. @ryanrdoherty

ryanrdoherty commented 2 years ago

I was a little sloppy; checked for nulls but not empty strings. Should be better now.

SheenaTomko commented 2 years ago

Looks great! Marking as complete