VEuPathDB / EdaSubsettingService

A REST service to provide data and subsetting in the Exploratory Data Analysis Workspace
Apache License 2.0
0 stars 0 forks source link

Fix subsetting metric paths #83

Closed dmgaldi closed 1 year ago

dmgaldi commented 1 year ago

Overview

I was looking at metrics in prometheus and subsetting has a label for every single study ID, entity ID and variable ID. The way I've approached it may be a little fragile, let me know if you have any suggestions.

dmgaldi commented 1 year ago

Hmm, I was looking at the code again and it looks like path parameters are supposed to be replaced by default. Maybe I need to look into what's going on for subsetting then

dmgaldi commented 1 year ago

As you mentioned, I think container core should have this already. Maybe we just need an upgrade?

Yeah, I'm going to close this PR. It looks like it's only on the count but not on the duration. I slacked Ellie to see if that's intentional or if it can be added there