VEuPathDB / EdaUserService

An EDA service that tracks user state
Apache License 2.0
0 stars 0 forks source link

Three tasks: upgrade and use latest gradle plugin features, improve DockerFile performance, wrap runtime exceptions #16

Closed dmgaldi closed 1 year ago

dmgaldi commented 1 year ago

Overview

Note: the makefile is now unnecessary, but is often convenient for development (no longer used in Dockerfile)

Testing

dmgaldi commented 1 year ago

I'm not actually sure I like this way better. Harder to track what all is going on. Like if I run make gen-jaxrs, I can track each step along the way. But by tacking on pre- and post-conditions to a "well known" gradle target, it could be a total mystery how it happens to someone not in the know.

Do you think we should have a gradle plugin task for fetching the RAML? I was hesitant since it's only done in EDA at the moment. I'm not sure how one would "opt into", "opt out of" or configure the common RAML fetch task if we put it in the plugin.

dmgaldi commented 1 year ago

I'm not actually sure I like this way better. Harder to track what all is going on. Like if I run make gen-jaxrs, I can track each step along the way. But by tacking on pre- and post-conditions to a "well known" gradle target, it could be a total mystery how it happens to someone not in the know.

Do you think we should have a gradle plugin task for fetching the RAML? I was hesitant since it's only done in EDA at the moment. I'm not sure how one would "opt into", "opt out of" or configure the common RAML fetch task if we put it in the plugin.

Talked about this after scrum, updated based on our conversation and Ellie's help

ryanrdoherty commented 1 year ago

@dmgaldi @Foxcapades Can you take a look at this as a final cut? I think it's ready to merge; can maybe be a template to improve all the other services (esp EDA services).

ryanrdoherty commented 1 year ago

@steve-fischer-200 Please review the Java code