VEuPathDB / EdaUserService

An EDA service that tracks user state
Apache License 2.0
0 stars 0 forks source link

Analyses can be renamed with extremely long names, which can cause a back end error #7

Closed bobular closed 3 years ago

bobular commented 3 years ago

Front end shows the usual We're sorry, something went wrong.

Message below shown in console

{"status":"server-error","message":"Unable to run SQL <update edauser.analysis set analysis_id = ?, user_id = ?, study_id = ?, study_version = ?, api_version = ?, display_name = ?, description = ?, creation_time = ?, modification_time = ?, is_public = ?, num_filters = ?, num_computations = ?, num_visualizations = ?, analysis_descriptor = ? where analysis_id = ?> with args [ 4bfe2c499bea9dfcc80b3ae1b43f32fc, 578013513, DS_2a6ace17a1, , , My cool analysis has an extremely long name, in fact my cool analysis has an extremely long name, in fact my cool analysis has an extremely long name, in fact my cool analysis has an extremely long name, in fact my cool analysis has an extremely long name, in fact my cool analysis has an extremely long name, in fact m, This is just a test analysis for EDA devs!\n\n(Imported from Jamie Long [University of Pennsylvania] on 07 Oct 2021 13:33:09 GMT.)\n\n(Imported from Bob MacCallum on 14 Oct 2021 09:37:42 GMT.), Thu Oct 14 09:37:4…
ryanrdoherty commented 3 years ago

Just added better checks on the backend so we throw 400 here instead of 500. That might be sufficient since having the client do it also would require either hard-coding the sizes in the client or sending them from the server.

ryanrdoherty commented 3 years ago

This is already fixed pending a new version of EdaUserService. I did not publish because it was right as we were about to branch for release and I didn't want to confuse things. Recommend we just wait and create a new release containing both this and the new "notes" clob (cannot find the issue) and https://github.com/VEuPathDB/EdaNewIssues/issues/23.

SheenaTomko commented 3 years ago

Going to mark this as closed but create a new separate low-priority ticket. We now get the 400 errors Ryan referenced, but they look different depending on where you try and rename an analysis