VEuPathDB / WDK

Apache License 2.0
1 stars 4 forks source link

ortho missing blast files did not throw error #76

Open aurreco-uga opened 10 months ago

aurreco-uga commented 10 months ago

Screen Shot 2023-12-20 at 8 18 46 AM

a user complained but if we had had emailed an error we would have fixed it long ago (asume it has been an issue since we released nov 28).

ryan slacks in ui-infra: Looks like the executable completes "successfully" (need to see if the process query checks return code), and then the text results are just what see. I found where we set the return code. We could easily throw exception if != 0, but that might have undesirable effects. Need to look more if you want to do something else here. We should try to define the behavior we want and then make sure it's doing what we want in WDK. Remember the issue where a plugin failed and then we cached 0 rows in the WDK cache as if it had succeeded with zero rows? I'm worried handling this non-zero return code as an exception might recause that issue.