Closed asizemore closed 1 year ago
I duplicated BinRange from the data service. There was LabeledRange in EdaCommon but that felt like more a data range. We should consolidate these in a future PR
LabeledRange
is the future. you should use that.
We should also add to EdaCommon a util getRBinListAsString that takes List<LabeledRange>
and returns the string R needs. we can also override that to take List<LabeledRangeWithValue>
, List<Range>
and List<String>
etc..
From slack: the LabeledRange in eda common won't be out until the release most likely, so we need to add a local version. i'll do that first thing tomorrow!
Requires microbiomeComputations
feature-41-diff-abund-cont-vars
Requires veupathUtilsadd-bin-helpers
Updates the differential abundance api to accept the comparator as an object with a variable and two bin lists.
Notes:
BinRange
from the data service. There wasLabeledRange
in EdaCommon but that felt like more a data range. We should consolidate these in a future PRgetRBinListAsString
from the data service inOverlaySpecification.java
. My duplicated code is again duplicated so my addition is utterly atrocious. I considered extending theBinRange
class so i could add this as a method, but the best fix would add something to EdaCommon and then update the data service and this diff abund file. Anyways, given the timing and that this PR is at least functional and has api we desire, i think it's worth a review and then a discussion about if implementing an extendedBinRange
class is worth the effort now if we know we need to do some edacommon work within the next build or so.Example post request