search

VEuPathDB / service-eda

Repo containing EDA web service
Apache License 2.0
0 stars 0 forks source link

Bug: protected passive studies are not being auto-approved after the approval window #47

Open danicahelb opened 3 months ago

danicahelb commented 3 months ago

Possibly related to https://github.com/VEuPathDB/EdaNewIssues/issues/785

Protected passive approval studies are NOT being automatically approved after the given approval window.

For example, Nicolette Zhou requested access to MAL-ED on May 1, 2024. As of May 23 the request was still pending. The study team did not take any action (since MALED is approved passively). The approval window is set to 14 days so this request should have been granted on May 14.

I granted access manually on May 23, but this action is not showing up in the data requestor table updates.

This issue seems to have cropped up around the time of b68 release.

image
danicahelb commented 3 months ago

Also note that Madeline Goosman requested access for GEMS1 on May 9 and as of May 23 still hadn't received access. GEMS1 has a 5 day approval window.

I manually approved this request on May 23

aurreco-uga commented 2 months ago

sorry for the delay, @Dan Galdi is fixing the jenkins job that runs daily to update this value. got broken with the last release updates on the eda service endpoints.

dmgaldi commented 2 months ago

A fix was deployed to QA, but not yet prod. I just updated the job to point to QA for now.

The fix will go to prod next time the services are deployed and we can update the job to point back at prod.