search

VEuPathDB / web-components

Library of React components for plotting data
Apache License 2.0
1 stars 0 forks source link

Mosaic elbow labels #418

Closed chowington closed 1 year ago

chowington commented 1 year ago

Works toward https://github.com/VEuPathDB/web-eda/issues/617 and https://github.com/VEuPathDB/web-components/issues/427

chowington commented 1 year ago

Realized my very dumb mistake after the meeting.....ready for review now!

chowington commented 1 year ago

Thanks DK! I didn't intentionally add any scrollbar function; that appears if the legend is taller than the Y axis. I did, however, fix some logic that was making the gap between the legend items too big. There will be some cases where, even with no gap, the legend will be too large, and in those cases the scrollbar should appear.

Plotly apparently shrinks the first column to make room for the scrollbar, and I don't see an easy way to change that. Anyway, it doesn't seem to shift any of the other columns. Also, I don't know why Plotly didn't show a scrollbar for those faceted plots---maybe it didn't quite think the legend was too tall yet. Anyway, I don't think there's an easy way to fix that either; it should happen less thanks to my latest commit though!

chowington commented 1 year ago

Oh, and yes, the labels bunched up at the end I think is expected behavior, since they have very few values.