VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

Styling: standardize icons #1111

Open asizemore opened 2 years ago

asizemore commented 2 years ago

Apologies if there is already an issue for this!

We've discussed it in the front end meetings but i found a really obvious example of mixing icons, so felt it was worth a github issue:

Screen Shot 2022-04-27 at 4 10 05 PM

There are two different trash cans and two different copy icons in the above image.

May be advantageous to address at the same time as web-eda #933

Depends on https://github.com/VEuPathDB/CoreUI/issues/67

dmfalke commented 2 years ago

I was thinking it might be nice to have a canonical list of icons in https://github.com/veupathdb/coreui. Any icon used by any site would have to be added there. The interface might be something like <Icon type="delete"/>. CoreUI would not provide a way to use a "custom" icon. This will force all variety of sites to be consistent about icon usage. I suppose we should have a separate issue in CoreUI. I'm happy to write it up.

asizemore commented 2 years ago

That would be incredible! Let's do that! Just made an issue in CoreUI. Please feel free to add more thoughts if you'd like!

asizemore commented 2 years ago

Then would this issue here become the implementation issue for web-eda? Like the issue that says "use coreui icons"?

dmfalke commented 2 years ago

That would be incredible! Let's do that!

Just made an issue in CoreUI. Please feel free to add more thoughts if you'd like!

Thanks!

dmfalke commented 2 years ago

Then would this issue here become the implementation issue for web-eda? Like the issue that says "use coreui icons"?

Yep, that sounds good to me!

danicahelb commented 2 years ago

other related tickets: https://github.com/VEuPathDB/web-eda/issues/936 https://github.com/VEuPathDB/web-eda/issues/927