search

VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

Histogram behaviour with respect to x-axis range change is inconsistent between subsetting and visualization #1443

Open bobular opened 2 years ago

bobular commented 2 years ago

Any change to the controls subsetting tab histogram controls causes a new back end request and so the bin width slider range is adjusted based on the response.

In the viz tab histogram a) at the time of writing, on the live site: changes to the x-axis range will trigger a new back end request (and the bin slider is adapted based on the response) b) at the time of writing, the latest main branch client code does not trigger a new back end request (as described above)

I think the behaviour in both subsetting and viz should be as in a) above. In particular the subsetting histogram should not be making new requests if the user toggles log scale on y-axis, for example.

Relates to https://github.com/VEuPathDB/web-eda/issues/1274

bobular commented 2 years ago

Update: #1444 now fixes the b) behaviour above and reverts it to a)

danicahelb commented 1 year ago

potentially related to https://redmine.apidb.org/issues/47693

I just talked with @d-callan about this, she commented:

Adding bin slider specs to variable metadata so that the workflow determines optimal bin slider min, max and step values in the same way in the subsetting tab as in the viz tab is more complicated than originally anticipated. I'm not sure the minor differences between subset and viz tabs are worth the effort.