search

VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

EDA: Update dataset (entity) diagram styling #1520

Open danicahelb opened 1 year ago

danicahelb commented 1 year ago

When we met with Kieran O’Brien (UCSF, Tom Lietman’s group) at ASTMH, she mentioned that she finds our dataset diagram a bit confusing, because, for instance, the Community repeated measures rectangle is placed directly under participants instead of under Community.

Please update styling of dataset diagram so that it is more in line with expectations of the community (ie, similar to epidemiology study flow charts).

Mockups: https://www.figma.com/file/QihFiBkvYIj4L6coS2olQG/Dataset-diagram---proposed-updates?node-id=0%3A1&t=2AutAs7uy0CQJIVN-0

image

Related to: https://github.com/VEuPathDB/EdaLoadingIssues/issues/30 and https://github.com/VEuPathDB/EdaLoadingIssues/issues/31

d-callan commented 1 year ago

the only question i have here is what to do w that pesky sample node in studies that might have samples collected on multiple entities, like household samples as well as participant samples? or what if samples werent collected repeatedly but other measures were? think mbio or vb might have some examples...

danicahelb commented 1 year ago

samples should have a timepoint indicated for collection even if not collected repeatedly, so we should still attach these to repeated measures.

We should discuss what to do about non-participant samples in other sites.

danicahelb commented 1 year ago

related ticket: https://github.com/VEuPathDB/EdaNewIssues/issues/487