search

VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

Bug in subset download modal not showing table #1568

Closed SheenaTomko closed 1 year ago

SheenaTomko commented 2 years ago

This has happened a couple of times. Today, I was looking at the West Africa ICEMR study on qa.restricted.clinepidb.org and went to download data. I opened the modal for household data and downloaded it with no issues, but for the Participant, Participant repeated measures, and Samples modals, when I clicked the checkbox to add all columns to the table, no table appeared. I was still able to download the data.

Screen Shot 2022-10-17 at 2 23 47 PM
SheenaTomko commented 2 years ago

Update: I tested additional studies and can't find a pattern to when I experience this and when I don't. In order I tried the following

  1. Kalifabougou Malaria Cohort (released study) - no issues
  2. JILINDE Costing (unreleased study) - same issue with the table preview not appearing
  3. Asia Pacific ICEMR (unreleased study) - no issues
  4. PPFP Choices (unreleased study) - no issues

This happens both if I click to select all or click on individual columns. I was able to download the subsetted data, just not preview it.

jernestmyers commented 2 years ago

I get the feeling this is related to an issue I experienced with my CheckboxTree work. An issue surfaced in genomics that I was surprised to not have encountered up to that point. I'll test my unmerged patch in this context to gauge my suspicions.

jernestmyers commented 1 year ago

Seems to be a backend issue: https://github.com/VEuPathDB/EdaSubsettingService/issues/81

danicahelb commented 1 year ago

possibly related to https://github.com/VEuPathDB/web-eda/issues/1522 & https://github.com/VEuPathDB/EdaDataService/issues/226#

dmfalke commented 1 year ago

I am going to close this, since it seems like #1522 addresses the issue with the user only seeing an "empty" modal.

SheenaTomko commented 1 year ago

Failed qa. Tested again on West Africa ICEMR Participant Repeated Measures subset download on qa.restricted.clinepidb.org. Now, instead of getting the empty space, I get a 500 error

SheenaTomko commented 1 year ago

This might be caused by the same issue identified in microbiome https://github.com/VEuPathDB/EdaDataService/issues/226#issuecomment-1344278636

jernestmyers commented 1 year ago

I think the confusion is that we have a couple issues related to this error. In my earlier comments, I diagnosed this as a backend error: https://github.com/VEuPathDB/EdaSubsettingService/issues/81

Then, Dave opened an issue related to how we aren't handling this backend error gracefully. I merged work to address that issue (https://github.com/VEuPathDB/web-eda/issues/1522), which I think is what prompted Dave to close this issue.

All that remains is the backend fix, as far as I can tell.

jernestmyers commented 1 year ago

Since it's a backend issue, I'm going to un-assign myself. I think that may be contributing to how/why this is still an open issue (though there is a clear backend ticket).

dmfalke commented 1 year ago

Sorry for the confusion. I was thinking that, since we now show the error in the modal, this issue can be considered complete. Before, we were just showing an empty modal, with no indication of an error. I suppose #1522 actually addresses that aspect of this issue. So, perhaps this can be considered a duplicate of https://github.com/VEuPathDB/EdaSubsettingService/issues/81, and therefore closed and complete?

SheenaTomko commented 1 year ago

Closing this as complete. Will link to it in the open ticket to aid qa