search

VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

banner control behaviors for lineplot #1589

Closed moontrip closed 1 year ago

moontrip commented 1 year ago

This will resolve https://github.com/VEuPathDB/web-eda/issues/1503. Several edge cases are also addressed:

a) the very basic and fundamental feature: no plotly display if banner is activated b) if no display, then no truncation or warning is shown either. c) better display that involves logScale banner: this relies on https://github.com/VEuPathDB/web-components/pull/447 d) keep banner(s) when going out of Viz and coming back

bobular commented 1 year ago

Hi @moontrip Sorry I don't have time for a full review. Y-axis looks great. I did some testing and noticed a small issue with the x-axis With the following GEMS1 example image Is it possible to avoid the data call and spinner when enabling binning?

moontrip commented 1 year ago

@bobular Thank you for your review and tests. I will check if it is possible, "avoid the data call and spinner when enabling binning"

moontrip commented 1 year ago

@bobular I have contemplated and tested your suggestion. My conclusion is that it is better to leave the current behavior as is. It is because that log scale toggle does not request a new data. For example, if both log scale and Binning are turned on then banner is shown and no plot is displayed. Under this condition, if only log scale is turned off (while Binning is on), banner disappears, however, no plot is still displayed because there is no data request.

Similar to this, Y-axis's Error bars request a new data (like Binning at X-axis), thus that's the reason why Y-axis case works

moontrip commented 1 year ago

Thank you for your detailed reviews/tests/suggestions which enhance this PR 👍