VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

use placeholderDisplayName if no variableId for y label #1591

Closed asizemore closed 1 year ago

asizemore commented 1 year ago

Resolves #1585

Previously the scatterplot was showing a value returned by the compute. This PR tells the scatterplot to use the placeholder name given by the abundance app instead of the variable display name returned by the compute, when a true variable isn't actually going to be returned.

I saw two options for solving this issue. The first is what i've done here, and the second is to update this line with a nicer display name.

I chose this route of updating the frontend because eventually this display name should be driven by collection variable metadata (that doesn't exist yet). The compute, however, does not know about collection metadata. It's called "Ranked Abundance" but really it could rank any type of data (for example, it also currently can be used to rank pathway coverage data. Anyways, once the collection variable metadata with display name does exist, we would plug that into the relevant part of the plugin Options.

Tested on mbio and clinepi

asizemore commented 1 year ago

courtesy tag @dmfalke