search

VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

Update beta diversity "distance" to "dissimilarity" #1628

Closed asizemore closed 1 year ago

asizemore commented 1 year ago

Technically, we are calculating dissimilarity values (do not respect triangle inequality) instead of distances.

asizemore commented 1 year ago

Looks like we're calling it "distance" in the backend as well, which makes this less trivial. Better to change all of them than to simply update the display name on the frontend. And while small, better we do it before beta div has gone public than after, so that we can prevent headaches of api mismatches and old computes with different params

asizemore commented 1 year ago

Cannot be qa-ed until the qa compute service is running v1.4.0.

To qa, please check that on Beta Div it says "Dissimilarity" instead of "Distance". Also please run a beta div computation and see if it runs!

SheenaTomko commented 1 year ago

Now see "Dissimilarity" rather than "Distance". Looks good :)