VEuPathDB / web-eda

Web browser code for EDA-based applications
Apache License 2.0
0 stars 0 forks source link

Bug: show user-friendly message when subset results table preview cannot be generated #1652

Closed danicahelb closed 1 year ago

danicahelb commented 1 year ago

I tried to download this:

image

and got this:

image
danicahelb commented 1 year ago

I don't think this is due to the server error in the table preview, as I am able to download MALED 16S data which has the same server error

aurreco-uga commented 1 year ago

table missing in eda-inc: eda.attributes_GEMS_1_entity_16SRRNAV1V2Assay

danicahelb commented 1 year ago

@aurreco-uga says:

for the previous download errors on assays, i see also missing: eda.attributes_DiabImmune_1_entity_16SRRNAV4Assay eda.attributes_MALED_diarrhea_1_entity_16SRRNAV4Assay

But I was able to download the 16S files for both MALED and DIABIMMUNE

jaycolin commented 1 year ago

We cannot build the wide table because, in most cases, assay entities have >1000 variables. Oracle has a hard limit of 1000 columns per table.

Steve's group should probably find an alternative way of handling download tab.

danicahelb commented 1 year ago

decison: Remove the My Subset section for mbio downloads. @dpbisme has suggested that most mbio users will not make a subset, so that functionality would likely not be so crucial.

We can fix the My Subset file problem for the next build and it'll look like we added a new feature

danicahelb commented 1 year ago

@asizemore I can now download GEMS 16S data, even though I still see the server error in the table preview section

Image

asizemore commented 1 year ago

Great! Okay that's good. I got all mixed up i guess about what tables could and couldn't be made. The user can download just fine, they just can't preview the table. I don't think this is something that needs to be resolved by b62, since very few users would use this feature.

asizemore commented 1 year ago

update again: we'll add some messaging based on the entity variables length. Assigning issue to me

danicahelb commented 1 year ago

Pull request indicates this verbiage:

image
danicahelb commented 1 year ago

@asizemore can we update the veribage to:

Preview is not available. You can still configure and download a tabular file of the filtered dataset.

asizemore commented 1 year ago

Sure! How about "... file of the subset"? I don't think "filter" is anywhere on that page

danicahelb commented 1 year ago

I took a lot of the verbiage from the description under "My subset". But I am also Ok with ... file of the subset.

image
danicahelb commented 1 year ago

looks great!

image