2x2 Mosaic plot Table is not being set up correctly

VEuPathDB / web-eda

Web browser code for EDA-based applications

Apache License 2.0

0 stars 0 forks source link

2x2 Mosaic plot Table is not being set up correctly #1663

Closed nkittur-uga closed 1 year ago

nkittur-uga commented 1 year ago

Please see example below from GEMS1 Case Control. Quadrant A (top left) values as selected by the user should have been "Case" "Yes" but in the table it is "Case" "No".

moontrip commented 1 year ago

Hi @nkittur-uga 👋 As far as I know, the contingency table was designed to follow the order of Y-axis data, e.g., Y-axis items shown in Mosaic plot. So, in this case, No is the first and Yes is the second (please see below screenshot).

mosaic-contingency-table

jernestmyers commented 1 year ago

For clarification, should the mosaic plot itself display "Case" "Yes" as its top left quadrant (A)? Or am I only changing the order in the table?

nkittur-uga commented 1 year ago

The plot can stay as it is. The table should match the quadrant selection. @danicahelb please confirm this

jernestmyers commented 1 year ago

I'm awaiting final approval to merge this fix, but these screenshots demonstrate the amended ordering.

nkittur-uga commented 1 year ago

Looks good. Thanks for fixing it!